-
Notifications
You must be signed in to change notification settings - Fork 36
Add std::cin cells to example notebooks #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add std::cin cells to example notebooks #329
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 20 20
Lines 950 950
Branches 87 87
=======================================
Hits 777 777
Misses 173 173 🚀 New features to boost your workflow:
|
|
Also does it really have to be +900-500 change diff to add 2 cells ? Looks a bit too much :\ |
5bde6eb to
4d5e775
Compare
|
Since |
8afabe7 to
7db0f4d
Compare
7db0f4d to
046c493
Compare
|
@SylvainCorlay @anutosh491 your comments have been addressed. This PR is ready for another review. |
|
Thanks. |



Description
Please include a summary of changes, motivation and context for this PR.
After #328 std::cin should work for xeus-cpp, so this adds this to the example notebooks.
Fixes # (issue)
Type of change
Please tick all options which are relevant.